feat: use XDG directories on Linux #1188
Open
+318
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this PR! I was thinking that we could add some utilities for this to the cli_util package and then use them across any dart programs. What do you think? See dart-archive/cli_util#94 |
|
can you make sure this also applies to macos? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for the
~/.dart_tooldirectory in user's HOME. It moves the config file to$XDG_CONFIG_HOME/dart_tool, and all other data to$XDG_DATA_HOME/dart_tool. If the old directory exists but the new one doesn't, the old location is used as a fallback. Otherwise, the new directories are created.See dart-lang/sdk#41560 (this doesn't fully solve the issue, but it does get rid of one of the offending directories)
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.